[PATCH 1/29] pinctrl: nomadik: simplify use of devm_ioremap_resource

Linus Walleij linus.walleij at linaro.org
Thu Aug 15 16:02:37 EDT 2013


On Wed, Aug 14, 2013 at 11:11 AM, Julia Lawall <Julia.Lawall at lip6.fr> wrote:

> From: Julia Lawall <Julia.Lawall at lip6.fr>
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource when the value is passed to devm_ioremap_resource.
>
> Move the call to platform_get_resource adjacent to the call to
> devm_ioremap_resource to make the connection between them more clear.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression pdev,res,n,e,e1;
> expression ret != 0;
> identifier l;
> @@
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, n);
>   ... when != res
> - if (res == NULL) { ... \(goto l;\|return ret;\) }
>   ... when != res
> + res = platform_get_resource(pdev, IORESOURCE_MEM, n);
>   e = devm_ioremap_resource(e1, res);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>

Patch applied.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list