[PATCH v6 02/11] irqchip: mmp: support irqchip

Daniel Drake dsd at laptop.org
Wed Aug 14 13:47:23 EDT 2013


On Tue, Aug 13, 2013 at 4:53 PM, Daniel Drake <dsd at laptop.org> wrote:
> generic_handle_irq() above looks up the descriptor for IRQ 13, but it
> does it without considering the mapping. So it picks up the descriptor
> for "legacy" interrupt 13 and passes that to icu_mask_ack_irq() -
> rather than passing the descriptor for the hwirq 13 that irq-mmp.c
> registered and was expecting (i.e. no translation was performed).
>
> How is this supposed to work?

All the users of irq_domain_add_linear() that I have looked at supply
a custom IRQ handler routine (via set_handle_irq) that does the
translation.

So this patch needs to be merged with patch 3 in the series (which
does just that), or the conversion from legacy to linear needs to
happen in patch 3, not this one. Personally I would just merge the 2
patches.

With patch 3 also applied, there is no more crash.

Thanks,
Daniel



More information about the linux-arm-kernel mailing list