[v2 rebased 1/2] dma: mmp_pdma: add support for residue reporting

Daniel Mack zonque at gmail.com
Wed Aug 14 12:15:51 EDT 2013


On 14.08.2013 14:46, Russell King - ARM Linux wrote:
> On Wed, Aug 14, 2013 at 02:25:20PM +0200, Daniel Mack wrote:
>> In order to report the channel's residue, we have to memorize the first
>> dma buffer position when the channel is configured.
> 
> This is actually broken, and I'm surprised that Vinod even suggested it.
> 
> Think about what happens with a scatter-gather list where the addresses
> of each element really are scattered in memory.  Let's say that the
> N'th element is at a lower address than the first element, and we're on
> that N'th element.  What happens when curr is less than chan->start_addr
> here:

Yes, you're right of course.

Then, we have no other chance than walking the list of all linked
descriptors. I just implemented this and it works. That approach also
saves us to memorize the start_addr in the channel struct.

I'll resend both patches - could you have another look?


Thanks,
Daniel




More information about the linux-arm-kernel mailing list