[PATCH v3 18/31] dts: mpc512x: add clock specs for client lookups

Gerhard Sittig gsi at denx.de
Sat Aug 3 11:36:30 EDT 2013


[ trimming the CC: list to device tree and ARM(clock) and PPC ]

On Fri, Aug 02, 2013 at 16:41 -0700, Mike Turquette wrote:
> 
> Quoting Gerhard Sittig (2013-07-22 05:14:45)
> > this addresses the client side of device tree based clock lookups
> > 
> > add clock specifiers to the mbx, nfc, mscan, sdhc, i2c, axe, diu, viu,
> > mdio, fec, usb, pata, psc, psc fifo, and pci nodes in the shared
> > mpc5121.dtsi include
> > 
> > these specs map 'clock-names' encoded in drivers to their respective
> > 'struct clk' items in the platform's clock driver
> > 
> > Signed-off-by: Gerhard Sittig <gsi at denx.de>
> 
> Reviewed-by: Mike Turquette <mturquette at linaro.org>

Thank you for the review, Mike!

Please note that there will be another update for the series.
These clock specs for client side lookups will have additional
'ipg' clock items next to 'mclk' for the PSC (UART, SPI) and
MSCAN (CAN) nodes.  But this change is straight forward.


> > ---
> >  arch/powerpc/boot/dts/mpc5121.dtsi |   79 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 79 insertions(+)
> > 
> > diff --git a/arch/powerpc/boot/dts/mpc5121.dtsi b/arch/powerpc/boot/dts/mpc5121.dtsi
> > index 8f4cba0..3657ae6 100644
> > --- a/arch/powerpc/boot/dts/mpc5121.dtsi
> > +++ b/arch/powerpc/boot/dts/mpc5121.dtsi
> > @@ -51,6 +51,10 @@
> >                 compatible = "fsl,mpc5121-mbx";
> >                 reg = <0x20000000 0x4000>;
> >                 interrupts = <66 0x8>;
> > +               clocks = <&clks MPC512x_CLK_MBX_BUS>,
> > +                        <&clks MPC512x_CLK_MBX_3D>,
> > +                        <&clks MPC512x_CLK_MBX>;
> > +               clock-names = "mbx-bus", "mbx-3d", "mbx";
> >         };
> >  
> >         sram at 30000000 {
> > @@ -64,6 +68,8 @@
> >                 interrupts = <6 8>;
> >                 #address-cells = <1>;
> >                 #size-cells = <1>;
> > +               clocks = <&clks MPC512x_CLK_NFC>;
> > +               clock-names = "per";
> >         };
> >  
> >         localbus at 80000020 {
> > @@ -153,12 +159,22 @@
> >                         compatible = "fsl,mpc5121-mscan";
> >                         reg = <0x1300 0x80>;
> >                         interrupts = <12 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_IPS>,
> > +                                <&clks MPC512x_CLK_SYS>,
> > +                                <&clks MPC512x_CLK_REF>,
> > +                                <&clks MPC512x_CLK_MSCAN0_MCLK>;
> > +                       clock-names = "ips", "sys", "ref", "mclk";
> >                 };
> >  
> >                 can at 1380 {
> >                         compatible = "fsl,mpc5121-mscan";
> >                         reg = <0x1380 0x80>;
> >                         interrupts = <13 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_IPS>,
> > +                                <&clks MPC512x_CLK_SYS>,
> > +                                <&clks MPC512x_CLK_REF>,
> > +                                <&clks MPC512x_CLK_MSCAN1_MCLK>;
> > +                       clock-names = "ips", "sys", "ref", "mclk";
> >                 };
> >  
> >                 sdhc at 1500 {
> > @@ -167,6 +183,9 @@
> >                         interrupts = <8 0x8>;
> >                         dmas = <&dma0 30>;
> >                         dma-names = "rx-tx";
> > +                       clocks = <&clks MPC512x_CLK_IPS>,
> > +                                <&clks MPC512x_CLK_SDHC>;
> > +                       clock-names = "ipg", "per";
> >                 };
> >  
> >                 i2c at 1700 {
> > @@ -175,6 +194,8 @@
> >                         compatible = "fsl,mpc5121-i2c", "fsl-i2c";
> >                         reg = <0x1700 0x20>;
> >                         interrupts = <9 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_I2C>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 i2c at 1720 {
> > @@ -183,6 +204,8 @@
> >                         compatible = "fsl,mpc5121-i2c", "fsl-i2c";
> >                         reg = <0x1720 0x20>;
> >                         interrupts = <10 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_I2C>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 i2c at 1740 {
> > @@ -191,6 +214,8 @@
> >                         compatible = "fsl,mpc5121-i2c", "fsl-i2c";
> >                         reg = <0x1740 0x20>;
> >                         interrupts = <11 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_I2C>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 i2ccontrol at 1760 {
> > @@ -202,30 +227,46 @@
> >                         compatible = "fsl,mpc5121-axe";
> >                         reg = <0x2000 0x100>;
> >                         interrupts = <42 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_AXE>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 display at 2100 {
> >                         compatible = "fsl,mpc5121-diu";
> >                         reg = <0x2100 0x100>;
> >                         interrupts = <64 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_DIU>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 can at 2300 {
> >                         compatible = "fsl,mpc5121-mscan";
> >                         reg = <0x2300 0x80>;
> >                         interrupts = <90 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_IPS>,
> > +                                <&clks MPC512x_CLK_SYS>,
> > +                                <&clks MPC512x_CLK_REF>,
> > +                                <&clks MPC512x_CLK_MSCAN2_MCLK>;
> > +                       clock-names = "ips", "sys", "ref", "mclk";
> >                 };
> >  
> >                 can at 2380 {
> >                         compatible = "fsl,mpc5121-mscan";
> >                         reg = <0x2380 0x80>;
> >                         interrupts = <91 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_IPS>,
> > +                                <&clks MPC512x_CLK_SYS>,
> > +                                <&clks MPC512x_CLK_REF>,
> > +                                <&clks MPC512x_CLK_MSCAN3_MCLK>;
> > +                       clock-names = "ips", "sys", "ref", "mclk";
> >                 };
> >  
> >                 viu at 2400 {
> >                         compatible = "fsl,mpc5121-viu";
> >                         reg = <0x2400 0x400>;
> >                         interrupts = <67 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_VIU>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 mdio at 2800 {
> > @@ -233,6 +274,8 @@
> >                         reg = <0x2800 0x800>;
> >                         #address-cells = <1>;
> >                         #size-cells = <0>;
> > +                       clocks = <&clks MPC512x_CLK_FEC>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 eth0: ethernet at 2800 {
> > @@ -241,6 +284,8 @@
> >                         reg = <0x2800 0x800>;
> >                         local-mac-address = [ 00 00 00 00 00 00 ];
> >                         interrupts = <4 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_FEC>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 /* USB1 using external ULPI PHY */
> > @@ -252,6 +297,8 @@
> >                         interrupts = <43 0x8>;
> >                         dr_mode = "otg";
> >                         phy_type = "ulpi";
> > +                       clocks = <&clks MPC512x_CLK_USB1>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 /* USB0 using internal UTMI PHY */
> > @@ -263,6 +310,8 @@
> >                         interrupts = <44 0x8>;
> >                         dr_mode = "otg";
> >                         phy_type = "utmi_wide";
> > +                       clocks = <&clks MPC512x_CLK_USB2>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 /* IO control */
> > @@ -281,6 +330,8 @@
> >                         compatible = "fsl,mpc5121-pata";
> >                         reg = <0x10200 0x100>;
> >                         interrupts = <5 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_PATA>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 /* 512x PSCs are not 52xx PSC compatible */
> > @@ -292,6 +343,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC0_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC1 */
> > @@ -301,6 +354,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC1_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC2 */
> > @@ -310,6 +365,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC2_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC3 */
> > @@ -319,6 +376,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC3_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC4 */
> > @@ -328,6 +387,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC4_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC5 */
> > @@ -337,6 +398,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC5_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC6 */
> > @@ -346,6 +409,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC6_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC7 */
> > @@ -355,6 +420,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC7_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC8 */
> > @@ -364,6 +431,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC8_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC9 */
> > @@ -373,6 +442,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC9_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC10 */
> > @@ -382,6 +453,8 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC10_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 /* PSC11 */
> > @@ -391,12 +464,16 @@
> >                         interrupts = <40 0x8>;
> >                         fsl,rx-fifo-size = <16>;
> >                         fsl,tx-fifo-size = <16>;
> > +                       clocks = <&clks MPC512x_CLK_PSC11_MCLK>;
> > +                       clock-names = "mclk";
> >                 };
> >  
> >                 pscfifo at 11f00 {
> >                         compatible = "fsl,mpc5121-psc-fifo";
> >                         reg = <0x11f00 0x100>;
> >                         interrupts = <40 0x8>;
> > +                       clocks = <&clks MPC512x_CLK_PSC_FIFO>;
> > +                       clock-names = "per";
> >                 };
> >  
> >                 dma0: dma at 14000 {
> > @@ -414,6 +491,8 @@
> >                 #address-cells = <3>;
> >                 #size-cells = <2>;
> >                 #interrupt-cells = <1>;
> > +               clocks = <&clks MPC512x_CLK_PCI>;
> > +               clock-names = "per";
> >  
> >                 reg = <0x80008500 0x100 /* internal registers */
> >                        0x80008300 0x8>; /* config space access registers */
> > -- 
> > 1.7.10.4


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de



More information about the linux-arm-kernel mailing list