[PATCH 1/3] gpio: 74x164: Add support for the daisy-chaining

Gabor Juhos juhosg at openwrt.org
Tue Sep 11 15:35:45 EDT 2012


2012.09.11. 19:05 keltezéssel, Linus Walleij írta:
> On Mon, Sep 10, 2012 at 10:35 PM, Maxime Ripard
> <maxime.ripard at free-electrons.com> wrote:
> 
>> The shift registers have an output pin that, when enabled, propagates
>> the values of its internal register to the pins. If another value comes
>> to the register while the output pin is disabled, this new value will
>> makae the older shift into the next register in the chain.
>>
>> This patch adds support for daisy-chaining the registers, using the
>> regular SPI chip select mechanism to manage the output pin, and the
>> registers-number dt property to set the number of chained registers.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> 
> OK cool, but I just realized that this driver was added just two
> years ago by Gabor and Miguel, so I'd like to get their feedback
> before continuing.
> 
> I know I already merged the DT support and stuff, but better
> late than never.
> 
> Please include them on future postings of patches to this
> driver... (See To: line)
> 
> Miguel, Gabor: please look at this, I hope you can get hold
> of the patches. Please also check the stuff I've already merged
> here:
> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=shortlog;h=refs/heads/devel

The merged patches look good in general. The merged patches look good in
general. However I don't know anything about the 74x164 chip. The driver contain
my copyright only because it was based on another driver which I wrote for a
different chip.

-Gabor



More information about the linux-arm-kernel mailing list