[PATCH] Nokia N9/N900/N950 -- mention product names

Aaro Koskinen aaro.koskinen at iki.fi
Wed Oct 17 15:25:25 EDT 2012


Hi,

Some minor comments:

On Wed, Oct 17, 2012 at 08:33:08PM +0200, Pavel Machek wrote:
> This adds product names (that most users know) to Kconfig and board
> comments.

Good idea. :-)

> Signed-off-by: Pavel Machek <pavel at ucw.cz>
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 346fd26..da08226 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -263,14 +263,14 @@ config MACH_NOKIA_N8X0
>  	select MACH_NOKIA_N810_WIMAX
>  
>  config MACH_NOKIA_RM680
> -	bool "Nokia RM-680/696 board"
> +	bool "Nokia N9/N950 (RM-680/696) phones"

This should be "N950/N9 (RM-680/RM-696)" or perhaps for clarity
"N950 (RM-680) / N9 (RM-696)".

>  	depends on ARCH_OMAP3
>  	default y
>  	select OMAP_PACKAGE_CBB
>  	select MACH_NOKIA_RM696
>  
>  config MACH_NOKIA_RX51
> -	bool "Nokia RX-51 board"
> +	bool "Nokia N900 phone (RX-51)"
>  	depends on ARCH_OMAP3
>  	default y
>  	select OMAP_PACKAGE_CBB
> diff --git a/arch/arm/mach-omap2/board-rm680.c b/arch/arm/mach-omap2/board-rm680.c
> index 0ad1bb3b..26965f3 100644
> --- a/arch/arm/mach-omap2/board-rm680.c
> +++ b/arch/arm/mach-omap2/board-rm680.c
> @@ -1,5 +1,5 @@
>  /*
> - * Board support file for Nokia RM-680/696.
> + * Board support file for Nokia N9/N950 (aka RM-680/696).

Same here.

Thanks,

A.



More information about the linux-arm-kernel mailing list