[PATCH] ARM: OMAP2+: Fix compiler warning for 32k timer

Jon Hunter jon-hunter at ti.com
Fri Nov 16 10:03:55 EST 2012


On 11/16/2012 01:52 AM, Felipe Balbi wrote:
> Hi,
> 
> On Thu, Nov 15, 2012 at 03:35:47PM -0600, Jon Hunter wrote:
>>
>> On 11/15/2012 02:45 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Nov 15, 2012 at 01:44:04PM -0600, Jon Hunter wrote:
>>>> +static struct of_device_id omap_counter_match[] __initdata = {
>>>
>>> not directly related to $SUBJECT, but shouldn't this be static const
>>> __initconst ?
>>
>> Yes you are right. Looks like there are several other of_device_id
>> structs in arch/arm/mach-omap2 that could be updated to const too.
> 
> here's a quick sed substitution for you:
> 
> $ sed -i 's/static \(struct of_device_id\)\s\(\w\+\[\]\)\s\(__initdata\|\)/static const \1 \2 __initconst/' arch/arm/*omap*/*.c
> 
> It worked fine here.

Thanks. Will fix this up in a subsequent patch.

Cheers
Jon




More information about the linux-arm-kernel mailing list