[PATCH 6/8] CI13xxx: Add i.MX233/i.MX28 binding code

[Felipe Balbi]

On Wed, May 16, 2012 at 03:41:17PM +0200, Marek Vasut wrote:
> Dear Felipe Balbi,
> 
> > On Tue, May 15, 2012 at 10:23:37AM +0200, Marek Vasut wrote:
> > > This codes connects the CI13xxx driver with the core found inside of
> > > the Freescale i.MX244/i.MX28 CPU.
> > > 
> > > Signed-off-by: Marek Vasut <marex at denx.de>
> > > Cc: Alan Stern <stern at rowland.harvard.edu>
> > > Cc: Detlev Zundel <dzu at denx.de>
> > > CC: Dong Aisheng <b29396 at freescale.com>
> > > CC: Fabio Estevam <fabio.estevam at freescale.com>
> > > Cc: Felipe Balbi <balbi at ti.com>
> > > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > > Cc: Linux ARM kernel <linux-arm-kernel at lists.infradead.org>
> > > Cc: linux-i2c at vger.kernel.org
> > > CC: Sascha Hauer <s.hauer at pengutronix.de>
> > > CC: Shawn Guo <shawn.guo at linaro.org>
> > > Cc: Stefano Babic <sbabic at denx.de>
> > > CC: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > > Cc: Wolfgang Denk <wd at denx.de>
> > > Cc: Wolfram Sang <w.sang at pengutronix.de>
> > > ---
> > > 
> > >  drivers/usb/chipidea/Makefile      |    4 +
> > >  drivers/usb/chipidea/ci13xxx_mxs.c |  201
> > >  ++++++++++++++++++++++++++++++++++++ 2 files changed, 205 insertions(+)
> > >  create mode 100644 drivers/usb/chipidea/ci13xxx_mxs.c
> > > 
> > > diff --git a/drivers/usb/chipidea/Makefile
> > > b/drivers/usb/chipidea/Makefile index cc34937..266d57d 100644
> > > --- a/drivers/usb/chipidea/Makefile
> > > +++ b/drivers/usb/chipidea/Makefile
> > > @@ -12,3 +12,7 @@ endif
> > > 
> > >  ifneq ($(CONFIG_ARCH_MSM),)
> > >  
> > >  	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_msm.o
> > >  
> > >  endif
> > > 
> > > +
> > > +ifneq ($(CONFIG_ARCH_MXS),)
> > > +	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_mxs.o
> > > +endif
> > 
> > NAK... let it compile everywhere.
> 
> I just followed the pattern here, honestly I think this is quite OK so far. 
> Further improvements can be made indeed.

why introduce something we know will change ? Just make sure your code
compiles everywhere. What's already there can be changed afterwards.

> > > +	*data->pdev->dev.dma_mask = DMA_BIT_MASK(32);
> > > +	data->pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> > 
> > why don't you just point to the parent's ?
> 
> Good idea, thanks :)

no problem ;-)

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120518/7a2cd354/attachment.sig>