[PATCHv5 1/8] ARM: OMAP4: suspend: Program all domains to retention

Kevin Hilman khilman at ti.com
Tue May 15 15:52:46 EDT 2012


Tero Kristo <t-kristo at ti.com> writes:

> From: Rajendra Nayak <rnayak at ti.com>
>
> Remove the FIXME's in the suspend sequence since
> we now intend to support system level RET support.

minor: this should probably go at the end of the series, after retention
is supported.  Otherwise, ending up with only this patch applied
(e.g. during a git bisect) will lead to a broken boot I suspect.

Kevin

> Signed-off-by: Rajendra Nayak <rnayak at ti.com>
> Signed-off-by: Tero Kristo <t-kristo at ti.com>
> Reviewed-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> ---
>  arch/arm/mach-omap2/pm44xx.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
> index 8856253..31990d5 100644
> --- a/arch/arm/mach-omap2/pm44xx.c
> +++ b/arch/arm/mach-omap2/pm44xx.c
> @@ -101,12 +101,6 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused)
>  	if (!strncmp(pwrdm->name, "cpu", 3))
>  		return 0;
>  
> -	/*
> -	 * FIXME: Remove this check when core retention is supported
> -	 * Only MPUSS power domain is added in the list.
> -	 */
> -	if (strcmp(pwrdm->name, "mpu_pwrdm"))
> -		return 0;
>  
>  	pwrst = kmalloc(sizeof(struct power_state), GFP_ATOMIC);
>  	if (!pwrst)



More information about the linux-arm-kernel mailing list