[PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality.

Rob Lee rob.lee at linaro.org
Wed May 2 10:09:12 EDT 2012


On Wed, May 2, 2012 at 9:07 AM, Shawn Guo <shawn.guo at linaro.org> wrote:
> On 2 May 2012 21:59, Rob Lee <rob.lee at linaro.org> wrote:
>>>> +             ret = cpuidle_register_device(dev);
>>>> +             if (ret) {
>>>> +                     pr_err("%s: Failed to register cpu %u\n",
>>>> +                             __func__, cpu_id);
>>>
>>> Nit: print ret (error code) too?
>>>
>>
>> I added the printing of the error code based on Sascha's suggestion in
>> v1 of this submission.
>>
> But you did not print "ret" in above pr_err.
>

Argh, sorry, still trying to wake up I guess.  Thanks.

> Regards,
> Shawn



More information about the linux-arm-kernel mailing list