[RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

Mohammed, Afzal afzal at ti.com
Wed Mar 28 01:04:51 EDT 2012


Hi Jon,

On Tue, Mar 27, 2012 at 21:01:56, Hunter, Jon wrote:
> > These are for the peripheral resources not in control of GPMC, like
> > gpio irq. These are copied in gpmc_create_child.
> 
> Right, I see they are copied during gpmc_create_child. However, I don't 
> see where they are initialised before that. The function 
> gpmc_setup_child is only initialising gpmc_res and gpmc_num_res and not 
> res and num_res. So I still don't see who is initialising these before 
> they are copied.

These are to be initialized by platform code, NAND have none so is
not currently seen, but devices like ethernet have to.

 
> I see you did not incorporate any clean-up in v2. Do you want me to send 
> you some patches to include?

Thanks for offering to help.

Cleanup is being deferred to be done once driver is finalized, I may
need your help later.

Regards
Afzal



More information about the linux-arm-kernel mailing list