[RFC/PATCH 4/4] pxa: convert to common clock framework

Philipp Zabel philipp.zabel at gmail.com
Mon Mar 19 04:51:32 EDT 2012


On Sun, Mar 18, 2012 at 6:43 AM, Shawn Guo <shawn.guo at linaro.org> wrote:
> Your patch #2 is trying to avoid the layering violation by separating
> static clock definitions and from clk_ops implementations into
> different files.  But ...
>
> On Fri, Mar 16, 2012 at 06:38:03PM +0100, Philipp Zabel wrote:
> ...
>> diff --git a/arch/arm/mach-pxa/clock.h b/arch/arm/mach-pxa/clock.h
>> index a3585a2..7c04f9b 100644
>> --- a/arch/arm/mach-pxa/clock.h
>> +++ b/arch/arm/mach-pxa/clock.h
>> @@ -1,80 +1,106 @@
>>  #include <linux/clkdev.h>
>> +#include <linux/clk-private.h>
>
> ... This is what I read from clk-private.h.

Thank you.
I could just remove that include line from clock.h, because it is only
needed for the static clock definition macros.
The pxa[23]?x.c, where they are used, already #include <clk-private.h> directly.
Or, to do it properly, clock.h could also be split in two.

regards
Philipp



More information about the linux-arm-kernel mailing list