[RFC 1/4] ARM: topology: Add arch_scale_freq_power function

Andy Whitcroft apw at canonical.com
Wed Jun 13 15:27:40 EDT 2012


On Wed, Jun 13, 2012 at 02:52:49PM +0200, Peter Zijlstra wrote:
> On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote:
> >         }
> >         smp_wmb();
> >  } 
> 
> You know what.. we should make checkpatch report an error for memory
> barriers that don't have a comment. 
> 
> I know this isn't added by this patch, but every time I see something
> like it I cry a little.

Actually if it was a new line, it would have been reported, at least in
theory:

    # check for memory barriers without a comment.
		    if ($line =~
    /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/)
    {
	if (!ctx_has_comment($first_line, $linenr)) {
	    CHK("MEMORY_BARRIER",
		"memory barrier without comment\n" . $herecurr);
	}
    }

-apw



More information about the linux-arm-kernel mailing list