[PATCH 07/11] ep93xx: Make syscon access functions private to SoC

H Hartley Sweeten hartleys at visionengravers.com
Fri Jan 13 12:38:38 EST 2012


On Tuesday, January 10, 2012 8:15 PM, Ryan Mallon wrote:
>
> The syscon access functions are no longer used outside of the
> core EP93xx code. Move their definitions into the SoC code.
> 
> Cc: Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Mika Westerberg <mika.westerberg at iki.fi>
> Signed-off-by: Ryan Mallon <rmallon at gmail.com>
> ---
>  arch/arm/mach-ep93xx/clock.c                 |    1 +
>  arch/arm/mach-ep93xx/core.c                  |    2 --
>  arch/arm/mach-ep93xx/include/mach/platform.h |   14 --------------
>  arch/arm/mach-ep93xx/soc.h                   |   14 ++++++++++++++
>  4 files changed, 15 insertions(+), 16 deletions(-)

It looks like part of this patch is word wrapped, or it could just be me...

<snip>

> diff --git a/arch/arm/mach-ep93xx/soc.h b/arch/arm/mach-ep93xx/soc.h index b0ef89b..958282a 100644
> --- a/arch/arm/mach-ep93xx/soc.h
> +++ b/arch/arm/mach-ep93xx/soc.h
> @@ -13,6 +13,20 @@
>  #ifndef _EP93XX_SOC_H
>  #define _EP93XX_SOC_H
>  
> +/* EP93xx System Controller software locked register write */ void 
> +ep93xx_syscon_swlocked_write(unsigned int val, void __iomem *reg); void 
> +ep93xx_devcfg_set_clear(unsigned int set_bits, unsigned int 
> +clear_bits);
> +
> +static inline void ep93xx_devcfg_set_bits(unsigned int bits) {
> +	ep93xx_devcfg_set_clear(bits, 0x00);
> +}
> +
> +static inline void ep93xx_devcfg_clear_bits(unsigned int bits) {
> +	ep93xx_devcfg_set_clear(0x00, bits);
> +}
> +
>  /*
>   * EP93xx Physical Memory Map:
>   *

I would prefer these functions to be after all the #define's.  But, your call...

Acked-by: H Hartley Sweeten <hsweeten at visionengravers.com>




More information about the linux-arm-kernel mailing list