[PATCH 1/2][RFC] at91 : move pm.h header to include/mach

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Jan 4 17:10:36 EST 2012


On Wed, Jan 04, 2012 at 11:31:05AM -0600, Rob Herring wrote:
> This header should probably be named something more specific like
> at91_pm.h or at91_sdram.h. This will be needed to avoid name collisions
> with mach headers on a single kernel binary.

I think actually the idea that mach/*.h headers can be included by stuff
outside of arch/arm is something that we should deprecate, because it's
not going to be sane to make them all unique in this way.

Not only that but it prevents the .c files being built on other
architectures, and provides another reason why the .c file is tied to
a pariticular SoC - even if the same IP is used in a different SoC, it
can be used as a reason why not to reuse the .c file.

Let's not give people excuses not to share code!



More information about the linux-arm-kernel mailing list