[PATCH 1/4 v2] i2c/gpio: add DT support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Feb 20 05:22:31 EST 2012


On 10:08 Mon 20 Feb     , Russell King - ARM Linux wrote:
> On Mon, Feb 20, 2012 at 10:58:13AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 18:17 Mon 13 Feb     , Karol Lewandowski wrote:
> > > > +	- udelay: delay between GPIO operations (may depend on each platform)
> > > > +	- timeout: timeout to get data (ms)
> > > 
> > > 
> > > If these are really needed then I would prefer to have these fully
> > > qualified (with unit type "-ms/-millisecs" appended).
> > > 
> > > Regulator framework, with its "-microvolt/-microamp", serve here as
> > > prime example of being quite descriptive (one doesn't neet to look up
> > > the docs). Please see:
> > > 
> > >   http://permalink.gmane.org/gmane.linux.ports.arm.omap/67637
> > timeout are usualy in ms I don't really see the need of -ms or so
> 
> Which is obviously total crap for udelay, which would be in _micro_seconds.
agreed but here on i2c gpio I never see timetout as udelay so I don't see
the mandatory to force the name in the binding

futhermore it's maybe linux specific

Best Regards,
J.



More information about the linux-arm-kernel mailing list