[PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses

phil.edworthy at renesas.com phil.edworthy at renesas.com
Wed Dec 12 05:12:27 EST 2012


Hi Simon, Laurent,

(resend as plain text)

> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> To: Phil Edworthy <phil.edworthy at renesas.com>, 
> Cc: Simon <horms at verge.net.au>, linux-sh at vger.kernel.org, linux-arm-
> kernel at lists.infradead.org, Magnus <magnus.damm at gmail.com>, Laurent 
> Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Date: 11/12/2012 11:39
> Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg 
addresses
> 
> On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
> > The INDTx register addresses were wrong.
> > 
> > Signed-off-by: Phil Edworthy <phil.edworthy at renesas.com>
> 
> You can add
> 
> Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Please scrap this patch. I just found out that it screws up the GPIO 
outputs. The current code assumes the same register is used for both input 
and output, which is not the case. It needs a bit of work to fix this.

Thanks
Phil



More information about the linux-arm-kernel mailing list