[PATCH v2] ARM: kirkwood: convert Guruplug Server Plus to use the device tree

Jason Cooper jason at lakedaemon.net
Sun Dec 9 18:57:29 EST 2012


On Sun, Dec 09, 2012 at 11:37:53PM +0100, Willy Tarreau wrote:
> On Sun, Dec 09, 2012 at 05:02:45PM -0500, Jason Cooper wrote:
> > > +	model = "Globalscale Technologies Guruplug Server Plus";
> > > +	compatible = "globalscale,guruplug-server-plug", "globalscale,guruplug", "marvell,kirkwood-88f6281", "marvell,kirkwood";
> > 
> > One small typo, should be "...server-plus".  If there are no other
> > comments over the next few days, I'll tweak it when I pull it in.
> 
> I'm amazed, because you did exactly the same one in your initial review
> last week and I noticed it back then. Then I did this one without copy-
> pasting yours! It seems like our brain is too much attracted by those
> similarly looking letters. Sorry for this one.

It's probably more of a pattern-completion mechanism in the brain.  We
type/think p-l-u-g more often than p-l-u-s.  So, when you are on
auto-pilot doing a simple change, the brain prefers 'g' over 's' to
complete p-l-u... Or, we're both just dumb. ;-)

I'm pretty sure there's a PhD candidate neurobiologist lurking on the
list who just found their thesis topic...

thx,

Jason.



More information about the linux-arm-kernel mailing list