[PATCH 2/2] ARM: imx6q: replace clk_register_clkdev with clock DT lookup

Shawn Guo shawn.guo at linaro.org
Mon Aug 20 11:16:11 EDT 2012


On Mon, Aug 20, 2012 at 09:54:48AM -0500, Matt Sealey wrote:
> Yet another arbitrary array...
> 
> I'm not sure why you would move the registration lookup into the DT

Because I do not want to patch kernel every time I need a new lookup.
Furthermore, looking at function imx53_qsb_init in imx53-dt.c, you
will find that lookup for sgtl5000 is really board specific and should
go to device tree.

> and use an arbitrarily ordered array again. Sure, you're looking it up
> entirely within the device tree here, but a better solution would be
> to not name clocks twice, and structure your clock definition
> properly.
> 
> What's wrong with;
> 
> ccm at 020c4000 {
>    ...
>    my_clock: clock at 0 {
>        name = "my_clock_name";
>    }
> }
> 
> uart at nnnnnnnn {
>    ...
>    clocks = <&my_clock>;
> }
> 
> ?
> 
It turns a property into 185 nodes, which will just bloat the device
tree.  This issue has been discussed for a plenty of times.

-- 
Regards,
Shawn



More information about the linux-arm-kernel mailing list