[PATCH 12/14] MTD: atmel nand: fix gpio missing request

Linus Walleij linus.walleij at linaro.org
Wed Aug 15 05:05:03 EDT 2012


On Fri, Aug 10, 2012 at 3:02 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:

> without this the gpio will not be muxed as a gpio by the current custom pinmux
> or later by the pinctrl
(...)
> +       if (gpio_is_valid(host->board.det_pin))
> +               gpio_free(host->board.det_pin);
> +
> +       if (gpio_is_valid(host->board.enable_pin))
> +               gpio_free(host->board.enable_pin);
> +
> +       if (gpio_is_valid(host->board.rdy_pin))
> +               gpio_free(host->board.rdy_pin);
> +

If you use devm_gpio_request() you can probably get rid of this block of
code, but no big deal so:
Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list