[PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

Linus Walleij linus.walleij at linaro.org
Tue Aug 14 04:31:08 EDT 2012


On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones at linaro.org> wrote:

> There was a plan to place ab8500_irq_get_virq() calls in each AB8500
> child device prior to requesting an IRQ, but as we're no longer using
> Device Tree to collect our IRQ numbers, it's actually better to allow
> the core to do this during device registration time. So the IRQ number
> we pull from its resource has already been converted to a virtual IRQ.
>
> CC: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> CC: linux-input at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

This is looking good, I guess you need all patches to go in at the
same time so Dmitry's ACK is required.

FWIW:
Acked-by: Linus Walleij <linus.walleij at linaro.org>

BTW: this makes me suspect that the public ab8500_irq_get_virq()
interface can be *deleted* and the function made static in the
AB8500 driver, right?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list