[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot

Shawn Guo shawn.guo at linaro.org
Wed Aug 8 10:41:51 EDT 2012


On Tue, Aug 07, 2012 at 07:15:25PM +0000, Arnd Bergmann wrote:
> > +       /* Power up fec phy */
> > +       gpio_set_value(TX28_FEC_PHY_POWER, 1);
> > +       mdelay(26); /* 25ms according to data sheet */
> 
> 26 ms is a long time for a delay. I think you should use msleep here.
> 
I copied this from TX28 board file.  But I just changed it per your
comment.  Thanks.

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list