[PATCH v2] arm: omap4: hsmmc: check for null pointer

T Krishnamoorthy, Balaji balajitk at ti.com
Wed Apr 25 07:54:39 EDT 2012


On Mon, Apr 23, 2012 at 8:13 PM, Felipe Balbi <balbi at ti.com> wrote:
> Hi,
>
> On Mon, Apr 23, 2012 at 08:11:07PM +0530, Balaji T K wrote:
>> +int __init omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers)
>> +{
>> +     struct omap2_hsmmc_info *c;
>> +
>> +     omap_hsmmc_init(controllers);
>> +     for (c = controllers; c->mmc; c++) {
>> +             /* pdev can be null if CONFIG_MMC_OMAP_HS is not set */
>> +             if (!c->pdev)
>> +                     continue;
>> +             omap4_twl6030_hsmmc_set_late_init(&c->pdev->dev);
>> +     }
>> +
>> +     return 0;
>> +}
>
> why are you even calling this if CONFIG_MMC_OMAP_HS isn't set ? Just
> stub it out if you don't have mmc support.

Ok, added in v3



More information about the linux-arm-kernel mailing list