[PATCH v6 09/10] ARM: S5PC100: Modify platform data for pl330 driver

Kukjin Kim kgene.kim at samsung.com
Wed Oct 12 00:52:12 EDT 2011


Thomas Abraham wrote:
> 
> Hi Anca,
> 
> On 12 October 2011 09:41, Anca Emanuel <anca.emanuel at gmail.com> wrote:
> > On Mon, Oct 10, 2011 at 9:15 PM, Thomas Abraham
> > <thomas.abraham at linaro.org> wrote:
> > <spnip>
> >
> >> +u8 pdma1_peri[] = {
> >> +       DMACH_UART0_RX,
> >> +       DMACH_UART0_TX,
> >> +       DMACH_UART1_RX,
> >> +       DMACH_UART1_TX,
> >> +       DMACH_UART2_RX,
> >> +       DMACH_UART2_TX,
> >> +       DMACH_UART3_RX,
> >> +       DMACH_UART3_TX,
> >> +       DMACH_IRDA,
> >> +       DMACH_I2S0_RX,
> >> +       DMACH_I2S0_TX,
> >> +       DMACH_I2S0S_TX,
> >> +       DMACH_I2S1_RX,
> >> +       DMACH_I2S1_TX,
> >> +       DMACH_I2S2_RX,
> >> +       DMACH_I2S2_TX,
> >> +       DMACH_SPI0_RX,
> >> +       DMACH_SPI0_TX,
> >> +       DMACH_SPI1_RX,
> >> +       DMACH_SPI1_TX,
> >> +       DMACH_SPI2_RX,
> >> +       DMACH_SPI2_TX,
> >> +       DMACH_PCM0_RX,
> >> +       DMACH_PCM1_TX,
> >
> > typo ?  DMACH_PCM0_TX
> 
> Yes. That is a mistake. I cross-checked others with the user manual
> and they are fine.
> 

OK, I think you don't need to re-send because I can fix it when I apply.
It would be helpful to me if you could check your patches again :)

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


> Thanks for pointing this out.
> 
> >
> >> +       DMACH_PCM1_RX,
> >> +       DMACH_PCM1_TX,
> >> +       DMACH_MSM_REQ0,
> >> +       DMACH_MSM_REQ1,
> >> +       DMACH_MSM_REQ2,
> >> +       DMACH_MSM_REQ3,
> >>  };
> >




More information about the linux-arm-kernel mailing list