[PATCH 4/5 v4] Realview PCIX support - add main support module code

Colin Tuckley colin.tuckley at arm.com
Mon Oct 10 05:32:20 EDT 2011


> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Subject: Re: [PATCH 4/5 v4] Realview PCIX support - add main support
> module code

Russell said:

> I thought one of my previous review points on this was that it was
> completely unsafe to match only on dev->device, rather than on both
> dev->device and dev->vendor.  Device IDs are allocated by individual
> vendors and are meaningless without also checking the vendor ID.

And

> And I thought we'd got to the point where we had a swizzle here.

The patch I sent to the list was indeed an old version. However the reason
is that despite the testing we did and your suggested changes the swizzle
based code still does not fully work. So I thought it best to post working
code.

I'm still waiting for a response from you on the last round of test results
I sent.

Regards,

Colin






More information about the linux-arm-kernel mailing list