[PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR

Russell King - ARM Linux linux at arm.linux.org.uk
Tue May 10 16:32:33 EDT 2011


On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote:
> I was blindly trusting code already in mainline again, and for that I
> apologize, I finally took the time to look at the implementation
> of IS_ERR() and test its use, and being IS_ERR(NULL) true it is not what
> we want indeed, see the attached test program.
> 
> So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL();
> how does that sound? Am I still missing anything?

That sounds a lot better, and should avoid the issue which caused me to
throw out the original patch.



More information about the linux-arm-kernel mailing list