[PATCH 08/10] omap2+: Use dmtimer macros for clocksource

Kevin Hilman khilman at ti.com
Mon Jun 27 12:41:42 EDT 2011


Tony Lindgren <tony at atomide.com> writes:

> * Tony Lindgren <tony at atomide.com> [110627 00:50]:
>> * Kevin Hilman <khilman at ti.com> [110623 10:06]:
>> > Tony Lindgren <tony at atomide.com> writes:
>> > > +
>> > > +	res = omap_dm_timer_init_one(&clksrc, gptimer_id, fck_source);
>> > 
>> > This function makes calls into "real" driver, but is called from
>> > sys_timer.init so happens before driver is initialized.
>> 
>> That one is the static omap2+ specific function that can be passed
>> to the dmtimer device driver as a function pointer in the later
>> patches. 
>>  
>> > > +	omap_dm_timer_set_load_start(&clksrc, 1, 0);
>> > 
>> > Here's another call into the real driver.  I think you need
>> > __omap_dm_timer_set_load_start() here.
>> 
>> Thanks, that's correct. Will fix that one.
>
> Here's this one updated. Looks like I still have your Reviewed-by
> lines from the last time this series got posted. Can you please check
> if those are still valid?

Yes, they're still valid as I've now been through the whole series.

Kevin



More information about the linux-arm-kernel mailing list