[PATCH 05/10] omap2+: Use dmtimer macros for clockevent

Tony Lindgren tony at atomide.com
Mon Jun 27 03:39:24 EDT 2011


* Kevin Hilman <khilman at ti.com> [110623 10:02]:
> Tony Lindgren <tony at atomide.com> writes:
> 
> > This patch makes timer-gp.c to use only a subset of dmtimer
> > functions without the need to initialize dmtimer code early.
> >
> > Also note that now with the inline functions, timer_set_next_event
> > becomes more efficient in the lines of assembly code.
> >
> > Signed-off-by: Tony Lindgren <tony at atomide.com>
> > Reviewed-by: Kevin Hilman <khilman at ti.com>
> 
> In order for this to work, *all* the dmtimer functions need to be
> converted.  Some still call the real driver, which may not yet be
> initialized (as pointed out for [7/10]...

Well omap_dm_timer_init_one is a static omap2plus specific
implementation that can then be then passed as a function pointer
to the dmtimer device driver in later patches.
 
> >  	gptimer = omap_dm_timer_request_specific(gptimer_id);
> 
> Here remains a call to the real driver, which is not yet initialized
> when called from sys_timer.init.

There's no need for omap_dm_timer_request_specific after the later
patches. It gets removed in the PM_DEBUG sysfs interface removal patch.

Tony



More information about the linux-arm-kernel mailing list