[PATCH 1/3] leds: create a trigger for ARM CPU activity

Nicolas Pitre nicolas.pitre at linaro.org
Wed Jun 22 15:06:16 EDT 2011


On Wed, 22 Jun 2011, Linus Walleij wrote:

> From: Linus Walleij <linus.walleij at linaro.org>
> 
> Attempting to consolidate the ARM LED code, this removes the
> custom RealView LED trigger code to turn LEDs on and off in
> response to CPU activity and replace it with a standard trigger.
> It uses the existing kernel hooks deep inside <asm/leds.h> to
> get CPU activity.
> 
> Cc: Bryan Wu <bryan.wu at canonical.com>
> Cc: Richard Purdie <rpurdie at rpsys.net>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>

Looks nice to me.  You don't handle the led_timer event, but since there 
is already a ledtrig-heartbeat trigger available, the conversion to the 
generic LED API can use that by default.

Acked-by: Nicolas Pitre <nicolas.pitre at linaro.org>

Converting all remaining users of leds_event would be a great thing too.


Nicolas



More information about the linux-arm-kernel mailing list