[PATCH 04/18] dmaengine/amba-pl08x: Remove redundant comment and rewrite original

viresh kumar viresh.linux at gmail.com
Sun Jul 31 01:51:38 EDT 2011


On 7/30/11, Linus Walleij <linus.walleij at linaro.org> wrote:
> 2011/7/31 Russell King - ARM Linux <linux at arm.linux.org.uk>:
>> On Sun, Jul 31, 2011 at 12:32:55AM +0200, Linus Walleij wrote:
>>> The PL08x has two bus mastering interfaces. They can be
>>> connected to two separate busses and two adress spaces
>>> even, usually that is not the case though.
>>
>> This is not what the function is about... that's done by my
>> pl08x_select_bus() function.
>
> To be clear, I was explaining what I percieved as a
> question from Viresh about what the comment in this hunk of
> the patch was about:
>

Just to clear my question again:
- It wasn't about the comment but concept behind Master/Slave terminology.
- Why are we referring src and dest as Master and Slave. As there is
nothing like that.
- As pointed by Russell and me earlier: Probably it is for choosing
the victim for
reduction of width, in case src and dest addresses are misaligned to each other.

If what i understood is correct, then we should get rid of this
routine or this master/slave
terminology, as this is causing confusion.

--
viresh



More information about the linux-arm-kernel mailing list