[PATCH 18/18] dmaengine/amba-pl08x: Call pl08x_free_txd() instead of calling kfree() directly

viresh kumar viresh.linux at gmail.com
Sun Jul 31 01:39:03 EDT 2011


On 7/30/11, Linus Walleij <linus.walleij at linaro.org> wrote:
> 2011/7/29 Viresh Kumar <viresh.kumar at st.com>:
>
>> pl08x_prep_channel_resources() is calling kfree() directly for txd(). To
>> maintain consistency in code call pl08x_free_txd() instead.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar at st.com>
>
> Good idea,
> Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yet there is a problem with this patch, as pointed by Russell.
pl08x_free_txd() must be called with channel lock taken. Will
check what can be done here.

--
viresh



More information about the linux-arm-kernel mailing list