[PATCH] OMAP2+: PM: fix watchdog boot when runtime PM is disabled

Paul Walmsley paul at pwsan.com
Wed Jul 13 03:54:41 EDT 2011


On Tue, 12 Jul 2011, Kevin Hilman wrote:

> Paul's concern is valid, and could be addressed by making that init code
> actually check if the WDT is currently active (as suggested by the
> comment there.)
> 
> In the mean time, this simple fix should be applied to prevent a boot
> crash, IMO.

Thing is, applying this fix will cause crashes if the bootloader enables 
the watchdog, but the kernel does not.  It just trades one source of 
crashes for another.

The root cause of this problem is that the drivers are incorrectly relying 
on runtime PM to "enable" devices.  My personal opinion is that we should 
be doing what SSB, PCI, etc. do, and have a omap_device_enable() that is 
called by the driver.  Basically, we need a real omap_bus/omap_device.

Meanwhile, switching to lazy device reset as Tony suggested should mask 
the issue.  The patches for this are 95% done; the intention is to post 
them for early 3.2.  Or if people are really gung-ho, 3.1 rc.


- Paul



More information about the linux-arm-kernel mailing list