[PATCH 16/17] mach-sa1100: retire custom LED code

Bryan Wu bryan.wu at canonical.com
Mon Jul 11 10:38:21 EDT 2011


On Mon, Jul 11, 2011 at 4:28 PM, Jochen Friedrich <jochen at scram.de> wrote:
> Hi Russell,
>
>>> +fs_initcall(simpad_leds_init);
>>
>> Looks like simpad is similarly afflicted.  I haven't gone through the
>> rest to check for similar issues.
>
> simpad is buggy in other means, as well (wrong bit, read of write-only
> register, missing locking). That's why I want to push my CS3 cleanup patch
> first, converting a custom IO to standard GPIO ;-)
>

if you can use this GPIO based gpio_led driver, there is not such
fs_initcall issue.

Thanks,
-- 
Bryan Wu <bryan.wu at canonical.com>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com



More information about the linux-arm-kernel mailing list