[PATCH] ARM: mmp: remove builtin gpio driver support

Eric Miao eric.y.miao at gmail.com
Mon Jul 11 07:44:09 EDT 2011


On Mon, Jul 11, 2011 at 1:05 PM, Haojian Zhuang
<haojian.zhuang at marvell.com> wrote:
> On Sat, 2011-07-09 at 21:02 -0700, Grant Likely wrote:
>> On Fri, Jul 08, 2011 at 06:20:18PM +0800, Haojian Zhuang wrote:
>> > Remove builtin gpio driver support form mmp.
>> >
>> > Signed-off-by: Haojian Zhuang <haojian.zhuang at marvell.com>
>>
>> Hi Haojian.
>>
>> I'm not clear what this patch is intending to do.  I understand that
>> it removes the mmp-specific gpio support, but I looks like don't see the code
>> that replaces it, which would mean that applying this patch breaks
>> gpio on mmp platforms.
>>
>> Am I missing something?
>>
> I'm sorry that I shouldn't loop this patch since my new gpio driver
> isn't contained in this patch series.
>
> I'm willing to add one operation to select using original gpio driver or
> the new one. Since the original gpio driver is shared between ARCH-PXA
> and ARCH-mmp. I don't want patch breaking the implementation in
> ARCH-PXA.

The built-in version is used for those timing critical situations. In some
best cases, it can be optimized to only one load/store instruction, which
is extremely useful for those bit-banging operations like I2C/SPI emulation
with GPIO.

>
> Thanks
> Haojian
>
>



More information about the linux-arm-kernel mailing list