[PATCH 1/3] ARM: CSR: Adding CSR SiRFprimaII board support

Barry Song 21cnbao at gmail.com
Wed Jul 6 21:20:29 EDT 2011


2011/7/7 Arnd Bergmann <arnd at arndb.de>:
> On Wednesday 06 July 2011 21:10:00 Russell King - ARM Linux wrote:
>> On Thu, Jul 07, 2011 at 12:09:24AM +0800, Barry Song wrote:
>> > if you define that in asm/io.h as you said:
>> >
>> > #ifndef IO_SPACE_LIMIT
>> > #if defined(PCMCIA_SOC_COMMON)
>> > #define  IO_SPACE_LIMIT ((resource_size_t)0xffffffff)
>> > #else
>> > #if defined(CONFIG_PCI) || defined(CONFIG_ISA) || defined(CONFIG_PCCARD)
>> > #define IO_SPACE_LIMIT ((resource_size_t)0xffff)
>> > #else
>> > #define IO_SPACE_LIMIT ((resource_size_t)0)
>> > #endif
>> > #endif
>> > #endif
>> >
>> > i'd like to delete IO_SPACE_LIMIT in my io.h.
>> >
>> > otherwise, i'd like to try "#define IO_SPACE_LIMIT
>> > ((resource_size_t)0)" in my io.h since i have no real
>> > CONFIG_PCI/ISA/PCCARD/PCMCIA_SOC_COMMON.
>>
>> Thanks - stopping the 0xffffffff madness in new platforms is great.
>
> FWIW, I've double-checked the Xilinx zynq platform that I've already queued
> up for 3.1: this one defines IO_SPACE_LIMIT to 0xffff because PCI support
> will get merged later, so that's fine.

as far as i know, zynq still has some static mapping tables and board
file board_dt.c. as you have reviewed csr platform very carefully, i
guess those can get fixed in zynq later too :-)
xilinx zynq and csr prima2 should be the pioneering two new SoCs to
move to DT in arm for the moment. at least, these two things can try
to get same.

>
>> If you also omit the definition for __io() and set NO_IOPORT in your
>> Kconfig, you should also end up with inb() et.al. undefined by asm/io.h,
>> which should cause build-time failures if an ISA/PCI/PCMCIA driver
>> attempts to build.
>
> Just as a follow-up, this is what I was referring to in the other
> sub-thread. Setting NO_IOPORT and removing __io does work for a lot
> of things today, but breaks randconfig builds left and right. I want
> to clean that up by adding 'depends on HAS_IOPORT' at the correct places
> and then switch all platforms that don't need it to remove __io.
>
>        Arnd
>



More information about the linux-arm-kernel mailing list