[PATCH 3/3] mmc: sdhci-esdhc-imx: add device tree probe support

Grant Likely grant.likely at secretlab.ca
Tue Jul 5 13:20:48 EDT 2011


On Tue, Jul 5, 2011 at 9:35 AM, Shawn Guo <shawn.guo at freescale.com> wrote:
> On Mon, Jul 04, 2011 at 12:25:48AM -0600, Grant Likely wrote:
>> > +    "none" : No CD
>> > +    "controller" : Uses eSDHC controller internal CD signal
>> > +    "gpio" : Uses GPIO pin for CD
>>
>> I would say the presence of a "cd-gpios" property would implicitly
>> mean gpio is to be used for the CD pin.
>>
> Yes, you are right.  But I would say this is a direct translation of
> the existing platform_data.  After all, we are sharing most of code
> path between platform and dt.

Meh, that's just implementation detail and the DT bindings should
*not* be focused on what Linux happens to currently do.  Define a
binding that makes sense first and foremost, and then make the driver
use it.

g.



More information about the linux-arm-kernel mailing list