[PATCH v2] arm: Configure reference clock for Versatile Express timers

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 24 11:14:53 EST 2011


On Mon, Jan 24, 2011 at 04:12:16PM +0000, Pawel Moll wrote:
> > > -   writel(0, MMIO_P2V(V2M_TIMER0) + TIMER_CTRL);
> > > -   writel(0, MMIO_P2V(V2M_TIMER1) + TIMER_CTRL);
> > BTW, why are you removing the initialization of TIMER_CTRL ?  You
> > don't
> > describe why you do this in the commit log so I suspect it's a
> > mistake.
> 
> Uh, apologies. The explanation got lost while moving the patch between
> one tree and another...
> 
> I've removed them, because the sp804 driver is initializing these
> registers in sp804_clocksource_init() and sp804_set_mode(), just a
> jiffy later.

What if we have some other more preferable clock events which
rules in set_mode not being called?  How do we ensure that these
timers won't create some spurious interrupts?



More information about the linux-arm-kernel mailing list