[PATCH 6/6] Fix eseries compilation if w100fb is not compiled in kernel

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Jan 5 05:54:04 EST 2011


Hello again,

On Wed, Jan 05, 2011 at 09:27:49AM +0100, Uwe Kleine-König wrote:
> Hello Dmitry,
> 
> On Wed, Jan 05, 2011 at 05:05:10AM +0300, Dmitry Eremin-Solenikov wrote:
> > e800_tg_change depends on w100fb_gpio_read/write API which is only present
> > if w100fb is compiled in kernel.
> > 
> > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov at gmail.com>
> > Cc: Ian Molton <ian at mnementh.co.uk>
> > ---
> >  arch/arm/mach-pxa/eseries.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-pxa/eseries.c b/arch/arm/mach-pxa/eseries.c
> > index b25690c..ed2c157 100644
> > --- a/arch/arm/mach-pxa/eseries.c
> > +++ b/arch/arm/mach-pxa/eseries.c
> > @@ -829,6 +829,7 @@ static struct w100_mem_info e800_w100_mem_info = {
> >  
> >  static void e800_tg_change(struct w100fb_par *par)
> >  {
> > +#ifdef FB_W100
> CONFIG_FB_W100?
> 
> >  	unsigned long tmp;
> >  
> >  	tmp = w100fb_gpio_read(W100_GPIO_PORT_A);
> > @@ -837,6 +838,7 @@ static void e800_tg_change(struct w100fb_par *par)
> >  	else
> >  		tmp &= ~0x100;
> >  	w100fb_gpio_write(W100_GPIO_PORT_A, tmp);
> > +#endif
> What happens if FB_W100=m?  The code isn't compiled in, would it still
> be necessary?
did you see commit a74b74a5555c741ed3df896096e33b853995631e?

http://git.kernel.org/linus/a74b74a5555c741ed3df896096e33b853995631e

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list