[PATCH] ARM: EXYNOS4: Adds Samsung NURI board support

Minkyu Kang mk7.kang at samsung.com
Mon Feb 28 03:14:01 EST 2011


Dear Kukjin Kim,

2011-02-28 오후 4:42, Kukjin Kim 쓴 글:
> Minkyu Kang wrote:
>>
>> This patch adds Samsung NURI board support.
>>
>> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>> ---
>> This patch is base on next-exynos4 branch at kgene tree.
>>
>>  arch/arm/configs/exynos4_defconfig |    1 +
>>  arch/arm/mach-exynos4/Kconfig      |   15 +++
>>  arch/arm/mach-exynos4/Makefile     |    1 +
>>  arch/arm/mach-exynos4/mach-nuri.c  |  233
>> ++++++++++++++++++++++++++++++++++++
>>  4 files changed, 250 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/mach-exynos4/mach-nuri.c
>>
> 
>> +enum fixed_regulator_id {
>> +	FIXED_REG_ID_MMC = 0,
> 
> 	FIXED_REG_ID_MMC,
> 
> (snip)
> 
>> +static struct platform_device emmc_fixed_voltage = {
>> +	.name			= "reg-fixed-voltage",
>> +	.id			= FIXED_REG_ID_MMC,
> 
> Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?
> 

I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on.
So use enum values for avoid the hard coding.

Thanks.
Minkyu Kang.



More information about the linux-arm-kernel mailing list