[PATCH 2/5] ARM: omap: update GPIO chained IRQ handler to use EOI in parent chip

Will Deacon will.deacon at arm.com
Tue Feb 22 13:30:01 EST 2011


Hi Santosh,

> > > On OMAP4, gpio_irq_handler can be chained to a physical interrupt
> > > using
> > > the GIC as the primary IRQ chip. Now that the GIC uses the fasteoi
> > > flow
> > > model, the chained handler must invoke ->irq_eoi once handling is
> > > complete.
> > >
> > > This patch adds a conditional call to ->irq_eoi in the GPIO IRQ
> > > handler
> > > for OMAP platforms. For OMAP implementations using other primary
> > > interrupt controllers, the ->irq_ack call remains and is also made
> > > conditional on the support offered by the controller.
> > >
> > > Cc: Santosh Shilimkar <santosh.shilimkar at ti.com>
> > > Cc: Colin Cross <ccross at google.com>
> > > Signed-off-by: Will Deacon <will.deacon at arm.com>
> > > ---
> > Thanks Will for changes. They look fine.
> > Acked-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> >
> > I will test your series tomorrow on OMAP with some
> > GPIO interrupts.
> >
> Tested your series on OMAP4 SDP, where GPIO is used for
> ethernet interrupts. They seems to work as expected.
> For omap changes,
> 	Tested-by: Santosh Shilimkar <santosh.shilimkar at ti.com>

That's good news, thanks! One down, three to go...

Will






More information about the linux-arm-kernel mailing list