[PATCH V5 41/63] ST SPEAr: replace readl, writel with readl_relaxed, writel_relaxed in uncompress.h

viresh kumar viresh.linux at gmail.com
Sat Feb 19 12:16:53 EST 2011


On 2/19/11, Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:
> On Thu, Jan 20, 2011 at 12:56:19PM +0530, Viresh Kumar wrote:
>> readl also calls outer cache maintainance operations which are not
>> available
>> during Linux uncompression. This patch replaces readl, writel with
>> readl_relaxed
>> and writel_relaxed.
>
> Shouldn't this be near the start of the series?
>

Yes.

> Also, would:
>
> "SPEAr: replace readl, writel with relaxed versions in uncompress.h
>
> readl() and writel() calls the outer cache maintainance operations
> which are not available during Linux uncompression. This patch replaces
> readl() and writel() with readl_relaxed() and writel_relaxed() to avoid
> the link time errors."
>
> be a better patch description?
>

Obviously. Will take care of such things next time we send a patch.

--
viresh



More information about the linux-arm-kernel mailing list