[PATCH 00/11] OMAP2+: clock: add clockfw autoidle for iclks, OMAP2xxx

Rajendra Nayak rnayak at ti.com
Fri Feb 18 00:33:04 EST 2011


Hi Paul,

> -----Original Message-----
> From: Paul Walmsley [mailto:paul at pwsan.com]
> Sent: Thursday, February 17, 2011 3:44 AM
> To: Rajendra Nayak
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: RE: [PATCH 00/11] OMAP2+: clock: add clockfw autoidle for
iclks, OMAP2xxx
>
> Hi Rajendra
>
> On Wed, 16 Feb 2011, Rajendra Nayak wrote:
>
> > > -----Original Message-----
> > > From: linux-arm-kernel-bounces at lists.infradead.org
> > [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf
> > > Of Paul Walmsley
> > > Sent: Wednesday, February 16, 2011 12:23 PM
> > >
> > > This series also ensures that all clock autoidle is disabled during
> > > boot and only re-enabled if CONFIG_PM is enabled.
> >
> > This does not seem to be the case. Maybe something like the
> > below patch is what is missing..
>
> Thanks for the review, you are absolutely right.  Rather than the patch
> you sent, and since mach-omap2/pm.c is compiled in even if !CONFIG_PM,
> I'd propose a different approach.  Until we can sort out the
> CONFIG_PM/pm.c issue, probably it would make more sense to move the
> autoidle-enable as part of CONFIG_OMAP_RESET_CLOCKS.  Will send a patch
in
> reply to the original thread.

I had a look at the patch and it does look like a better way to handle
it for now, till the CONFIG options are further cleaned up.
Thanks,
Rajendra

>
>
> - Paul



More information about the linux-arm-kernel mailing list