[PATCHv2 2/2] Input: ads7846 - configure pendown gpio as input

[Varadarajan, Charulatha]

Sourav,

On Thu, Feb 3, 2011 at 15:28, Felipe Balbi <balbi at ti.com> wrote:
> On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote:
>> The ads7846 driver requests a gpio to detect pendown events,
>> but does not configure its direction. Configure this gpio
>> as an input after requesting it.
>>
>> Signed-off-by: Sourav Poddar <sourav.poddar at ti.com>
>> ---
>> changes between v2 and v1: Added return error support in v2.
>>
>> drivers/input/touchscreen/ads7846.c |    7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index 036f245..f30768b 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -962,6 +962,13 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
>>               return err;
>>       }
>>
>> +     err = gpio_direction_input(pdata->gpio_pendown);
>> +     if (err) {
>> +             dev_err(&spi->dev, "failed to configure pendown GPIO input direction %d\n",
>> +                     pdata->gpio_pendown);
>> +             return err;
>
> and now you miss a gpio_free().

My question to your previous version is still unanswered.
Would it be relevant to add gpio_set_debounce() for this
gpio?