[PATCH] serial/imx: propagate error from of_alias_get_id instead of using -ENODEV

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Dec 14 15:26:51 EST 2011


A quick look at of_alias_get_id shows that in the error case it returns
-ENODEV, too, but still it's better style to propagate the value as is.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Cc: Shawn Guo <shawn.guo at linaro.org>
Cc: Alan Cox <alan at linux.intel.com>
Cc: Grant Likely <grant.likely at secretlab.ca>
Cc: Jeremy Kerr <jeremy.kerr at canonical.com>
Cc: Jason Liu <jason.hui at linaro.org>
Cc: Sascha Hauer <s.hauer at pengutronix.de>
---
 drivers/tty/serial/imx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 163fc90..75c159a 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1301,7 +1301,7 @@ static int serial_imx_probe_dt(struct imx_port *sport,
 	ret = of_alias_get_id(np, "serial");
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to get alias id, errno %d\n", ret);
-		return -ENODEV;
+		return ret;
 	}
 	sport->port.line = ret;
 
-- 
1.7.7.3




More information about the linux-arm-kernel mailing list