[PATCH 1/7] arm/imx6: add imx6q sabrelite board support

Shawn Guo shawn.guo at freescale.com
Mon Dec 12 03:56:32 EST 2011


On Mon, Dec 12, 2011 at 03:50:48PM +0800, Richard Zhao wrote:
> > > > > +
> > > > > +	chosen {
> > > > > +		bootargs = "console=ttymxc1,115200";
> > > > > +	};
> > > > > +
> > > > Maybe we can start dropping this, since kernel is now able to get
> > > > bootargs from atags even in case that bootloader can not pass dtb
> > > > and the dtb is appended to kernel image.
> > > kernel has a config "Extend bootloader kernel arguments". Does it help
> > > such case?
> > 
> > CONFIG_ARM_APPENDED_DTB and CONFIG_ARM_ATAG_DTB_COMPAT
> I don't like puting cmdline in dts either, but kernel provide
> CONFIG_CMDLINE_EXTEND and CONFIG_CMDLINE_FORCE, it's better to at least
> let uart work. I don't quite insist on it.
> 
It's irrelevant.  My point is I do not see a real use case for this
'bootargs' from dts.  If your u-boot can pass dtb to kernel, it will
replace the chosen node with its own 'bootargs' parameter anyway.
If your u-boot is too old to pass dtb, you will probably need to enable
CONFIG_ARM_APPENDED_DTB and CONFIG_ARM_ATAG_DTB_COMPAT to append dtb
to kernel image and have kernel parse 'bootargs' from atags.

That said, in both case, we want to use bootargs set by bootloader.

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list