[PATCH v5 2/4] MTD : add the common code for GPMI controller driver

Huang Shijie b32955 at freescale.com
Thu Apr 14 02:40:58 EDT 2011


hi:
> Hi,
>
> Huang Shijie writes:
>>>> +	this->swap_block_mark = true;
>>>> +	if (GPMI_IS_MX23(this))
>>>> +		this->swap_block_mark = false;
>>>>
>>> if ... else ...?
>> else is "true" by default.
>>
> I meant it would be clearer to do:
> 	if (GPMI_IS_MX23(this))
> 		this->swap_block_mark = false;
> 	else
> 		this->swap_block_mark = true;
>
:)

thanks.

Huang Shijie
> Lothar Waßmann





More information about the linux-arm-kernel mailing list