[PATCH 0/2] ARM: factorise CPU hotplug code

Sundar R IYER sundar.iyer at stericsson.com
Tue Sep 7 05:32:04 EDT 2010


Hello,

>-----Original Message-----
>From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
>Sent: Monday, September 06, 2010 2:27 PM
>
>So what if a platform wants to completely power down a CPU?
>

Cannot this can be still implemented in the platform_do_lowpower()
inside the platform code? I think all that would be replaced for the
platform is the WFI portion, which might be accompanied by requests
to turn the core off.

>You'd want to implement it such that platform_cpu_die() does all
>the shutdown of the CPU except for power-off, and platform_cpu_kill()
>waits for that to complete before turning power off.
>
>With platform_cpu_kill() and platform_cpu_die() moved into generic
>code, you can no longer do this.

I am sorry but I didn't understand this. The erstwhile platform_cpu_die
contains helpers to prepare/enter/exit low power modes. Am I missing
something here that the prepare/enter/exit cannot be included in a 
do_low_power() which is platform specific?

>Lastly, what if you want to allow CPU0 to be offlined, which is
>possible, though its wake-up is a little more complex because it
>must not be allowed to go through its normal boot?

I moved this because none of the platforms currently support offlining
CPU0 in the current code. But, even if it may be possible, wouldn't it be
generic for the architecture?

Regards,
Sundar



More information about the linux-arm-kernel mailing list