[RFC] [PATCH v2] arm & sh: factorised duplicated clkdev.c

[Uwe Kleine-König]

Hi Russell,

On Thu, Sep 02, 2010 at 02:47:32PM +0100, Russell King - ARM Linux wrote:
> On Thu, Sep 02, 2010 at 03:26:41PM +0200, Uwe Kleine-König wrote:
> > I'm not very satisfied by Russell's answer.  But even if I accept that
> > it should not move to .init.text, why .ref.text?  If I'm not mistaken
> > clkdev_alloc references the following non-local symbols:
> > 
> > 	__clkdev_alloc
> > 	strlcpy
> > 	vscnprintf
> 
> __clkdev_alloc() is an inline function, so effectively it's part of this
> function.  On sh, this calls the boot time allocator which is marked as
> __init if the normal memory allocators aren't online yet.
ah, OK, so I suggest to do

	#ifdef CONFIG_SH
	__ref
	#endif

Just kidding :-)

> > Russell, would at least __module_or_init be OK?
> 
> It's a conceptual thing - we want to allow people to create aliases at
> run time.  Making it an __init thing will only encourage people to do
> silly things to work around the "it can only be used at init time"
> problem rather than taking the obvious step of removing the __init tag.
OK, thanks for your explanation.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |