[RFC PATCH] arm: msm: moved Kconfig machine entry into mach-msm

Daniel Walker dwalker at codeaurora.org
Fri Oct 22 11:20:00 EDT 2010


On Fri, 2010-10-22 at 08:49 +0100, Russell King - ARM Linux wrote:
> On Thu, Oct 21, 2010 at 11:37:35AM -0700, Daniel Walker wrote:
> > Has anyone suggested this? It seems like it might reduce conflicts
> > in the Kconfig file.
> 
> How?  The choice normally has one entry for each mach- directory.
> You're still going to have 'source' for each mach- directory, so
> the chances of conflicts are no different.

The source lines would be mostly static.. We wouldn't have to modify
Kconfig to add new "select" statements to are entries. People end up
having to send you patches which do something then modify the Kconfig
(or in some cases they don't send them to you which is worse) in order
to reduce conflicts. With this change they wouldn't need to do that.

> Plus it increases the file count, makes things more indirect, and
> therefore harder to follow.

True. It's a trade off , but we already have this for the other menu
options further down the Kconfig.

Daniel
-- 
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.





More information about the linux-arm-kernel mailing list