[PATCH 1/2] hwmon: add generic GPIO fan driver

Guenter Roeck guenter.roeck at ericsson.com
Thu Oct 21 16:26:38 EDT 2010


Hi Simon,

On Thu, Oct 21, 2010 at 04:07:10PM -0400, Simon Guinot wrote:
[ ... ]

> > > @@ -399,6 +399,15 @@ config SENSORS_GL520SM
> > >           This driver can also be built as a module.  If so, the module
> > >           will be called gl520sm.
> > > 
> > > +config SENSORS_GPIO_FAN
> > > +       tristate "GPIO fan"
> > > +       depends on GENERIC_GPIO
> > > +       help
> > > +         If you say yes here you get support for the GPIO connected fan.
> > > +
> > > +         This driver can also be built as a module.  If so, the module
> > > +         will be called gpio-fan.
> > > +
> > 
> > Can you move this up a bit, ahead of SENSORS_FSCHMD ? Trying to stay in sequence.
> 
> Ok. Let's try to figure out where is the right location :)
> After SENSORS_GL520SM or not ?
> 

My brain must have told me that "G" comes before "F". Or so. ABCDEGF, isn't it ?

After SENSORS_GL520SM. Sorry. Or whereever it fits in the alphabet,
if I got that wrong again ;).

Guenter




More information about the linux-arm-kernel mailing list